fix TestPidsSystemd and TestRunWithKernelMemorySystemd test error by XiaodongLoong · Pull Request #2501 · opencontainers/runc

XiaodongLoong · 2020-07-04T03:24:09Z

Test command : make localunittest
Test logs:

FAIL: TestPidsSystemd (0.08s)
   utils_test.go:55: exec_test.go:630: unexpected error: container_linux.go:353: starting container process caused: process_linux.go:326: applying cgroup configuration for process caused: mountpoint for devices not found
FAIL: TestRunWithKernelMemorySystemd (0.07s)
   exec_test.go:713: runContainer failed with kernel memory limit: container_linux.go:353: starting container process caused: process_linux.go:326: applying cgroup configuration for process caused: mkdir : no such file or directory

Root cause:
TestPidsSystemd: The cgroup root path is integration/test when the test container is stating. The devices subsystem can not find under this root path, then casue apply cgroup error. The code show as following,

runc/libcontainer/cgroups/systemd/v1.go

Line 274 in 3cb1909

if name == "devices" {

TestRunWithKernelMemorySystemd: The root cause is same as the TestPidsSystemd. But it leads to mkdir "", when system want to set "KernelMemory" property. See the code as following,

runc/libcontainer/cgroups/systemd/v1.go

Line 431 in 3cb1909

if err := os.MkdirAll(path, 0755); err != nil {

Signed-off-by: Xiaodong Liu liuxiaodong@loongson.cn

XiaodongLoong · 2020-07-06T06:49:24Z

@AkihiroSuda PTAL

AkihiroSuda · 2020-07-06T07:09:10Z

 }

 func testPids(t *testing.T, systemd bool) {
-	if testing.Short() {


Why remove this?

Just remove -short from CentOS 7 CI

runc/.travis.yml

Line 49 in 3cb1909

- sudo ssh default -t 'sudo -i make -C /vagrant localunittest TESTFLAGS=-short'

TESTFLAGS=-short' let about 53 test skip. But I just solved TestPidsSystemd and _TestRunWithKernelMemorySystemd_ test cases error.

IIUC we no longer need to skip any unit test on CentOS7 CI?

OK, I'll have a try.

All tests passed, 👍

XiaodongLoong · 2020-07-06T12:12:01Z

There is an error on fedora32 (failed to update) :
make : command not found
https://travis-ci.org/github/opencontainers/runc/jobs/705364254

XiaodongLoong · 2020-07-07T06:27:10Z

@kolyshkin PTAL

kolyshkin · 2020-07-07T21:40:56Z

There is an error on fedora32 (failed to update) :
make : command not found
https://travis-ci.org/github/opencontainers/runc/jobs/705364254

Addressed by #2511

kolyshkin · 2020-07-07T21:42:17Z

        # FIXME: the following unit tests are skipped (TESTFLAGS=-short):
        #        FAIL: TestPidsSystemd: utils_test.go:55: exec_test.go:630: unexpected error: container_linux.go:353: starting container process caused: process_linux.go:326: applying cgroup configuration for process caused: mountpoint for devices not found
        #        FAIL: TestRunWithKernelMemorySystemd: exec_test.go:713: runContainer failed with kernel memory limit: container_linux.go:353: starting container process caused: process_linux.go:326: applying cgroup configuration for process caused: mkdir : no such file or directory
-        - sudo ssh default -t 'sudo -i make -C /vagrant localunittest TESTFLAGS=-short'
+        - sudo ssh default -t 'sudo -i make -C /vagrant localunittest TESTFLAGS='


So, you need to remove the FIXME comment above, as well as TESTFLAGS.

Signed-off-by: Xiaodong Liu <liuxiaodong@loongson.cn>

kolyshkin

LGTM

XiaodongLoong force-pushed the systemderror-fix branch 2 times, most recently from 990947e to 96f64e9 Compare July 4, 2020 06:04

AkihiroSuda reviewed Jul 6, 2020

View reviewed changes

XiaodongLoong force-pushed the systemderror-fix branch from 96f64e9 to cea9981 Compare July 6, 2020 11:18

AkihiroSuda added area/cgroupv1 area/ci area/systemd labels Jul 6, 2020

XiaodongLoong force-pushed the systemderror-fix branch from cea9981 to 8e4fd69 Compare July 6, 2020 11:24

XiaodongLoong force-pushed the systemderror-fix branch from 8e4fd69 to 97e16e7 Compare July 7, 2020 02:34

AkihiroSuda previously approved these changes Jul 7, 2020

View reviewed changes

kolyshkin reviewed Jul 7, 2020

View reviewed changes

AkihiroSuda mentioned this pull request Jul 8, 2020

CentOS 7 CI: analyze failure of systemd unit tests and rootless integration tests #2473

Open

XiaodongLoong dismissed AkihiroSuda’s stale review via 24691a0 July 8, 2020 09:21

XiaodongLoong force-pushed the systemderror-fix branch from 97e16e7 to 24691a0 Compare July 8, 2020 09:21

AkihiroSuda previously approved these changes Jul 8, 2020

View reviewed changes

fix TestPidsSystemd and TestRunWithKernelMemorySystemd test error

f57bb2f

Signed-off-by: Xiaodong Liu <liuxiaodong@loongson.cn>

XiaodongLoong dismissed AkihiroSuda’s stale review via f57bb2f July 9, 2020 01:36

XiaodongLoong force-pushed the systemderror-fix branch from 24691a0 to f57bb2f Compare July 9, 2020 01:36

XiaodongLoong requested review from AkihiroSuda and kolyshkin July 9, 2020 02:23

AkihiroSuda approved these changes Jul 9, 2020

View reviewed changes

kolyshkin approved these changes Jul 9, 2020

View reviewed changes

kolyshkin merged commit fbf047b into opencontainers:master Jul 9, 2020

kolyshkin mentioned this pull request Oct 6, 2020

libcontainer/integration: fix cgroupv1 + systemd tests #2600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix TestPidsSystemd and TestRunWithKernelMemorySystemd test error#2501

fix TestPidsSystemd and TestRunWithKernelMemorySystemd test error#2501
kolyshkin merged 1 commit into
opencontainers:masterfrom
XiaodongLoong:systemderror-fix

XiaodongLoong commented Jul 4, 2020

Uh oh!

XiaodongLoong commented Jul 6, 2020

Uh oh!

AkihiroSuda Jul 6, 2020

Uh oh!

AkihiroSuda Jul 6, 2020 •

edited

Loading

Uh oh!

XiaodongLoong Jul 6, 2020

Uh oh!

AkihiroSuda Jul 6, 2020

Uh oh!

XiaodongLoong Jul 6, 2020

Uh oh!

XiaodongLoong Jul 7, 2020

Uh oh!

XiaodongLoong commented Jul 6, 2020 •

edited

Loading

Uh oh!

XiaodongLoong commented Jul 7, 2020

Uh oh!

kolyshkin commented Jul 7, 2020

Uh oh!

kolyshkin Jul 7, 2020 •

edited

Loading

Uh oh!

kolyshkin left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

XiaodongLoong commented Jul 4, 2020

Uh oh!

XiaodongLoong commented Jul 6, 2020

Uh oh!

AkihiroSuda Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XiaodongLoong Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

XiaodongLoong Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

XiaodongLoong Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

XiaodongLoong commented Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XiaodongLoong commented Jul 7, 2020

Uh oh!

kolyshkin commented Jul 7, 2020

Uh oh!

kolyshkin Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kolyshkin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AkihiroSuda Jul 6, 2020 •

edited

Loading

XiaodongLoong commented Jul 6, 2020 •

edited

Loading

kolyshkin Jul 7, 2020 •

edited

Loading