Skip to content

Allow libcontainer/configs to be imported on Windows#2514

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
rhatdan:windows
Jul 8, 2020
Merged

Allow libcontainer/configs to be imported on Windows#2514
mrunalp merged 1 commit into
opencontainers:masterfrom
rhatdan:windows

Conversation

@rhatdan
Copy link
Copy Markdown
Contributor

@rhatdan rhatdan commented Jul 8, 2020

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Copy Markdown
Contributor Author

rhatdan commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp mrunalp merged commit ce54a9d into opencontainers:master Jul 8, 2020
@kolyshkin
Copy link
Copy Markdown
Contributor

Related: containers/buildah#2652

@rhatdan looks like this PR is not needed any longer, or am I missing something? Asking as I'd like to revert it.

@rhatdan
Copy link
Copy Markdown
Contributor Author

rhatdan commented Dec 7, 2020

Sure, as long as Podman does not need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants