travis: don't hardcode golang versions#2538
Closed
kolyshkin wants to merge 2 commits intoopencontainers:masterfrom
Closed
travis: don't hardcode golang versions#2538kolyshkin wants to merge 2 commits intoopencontainers:masterfrom
kolyshkin wants to merge 2 commits intoopencontainers:masterfrom
Conversation
Golang is supporting two minor releases (currently 1.14.x and 1.13.x), and thus once a new minor release is out, the oldest supported one becomes unsupported (e.g. when 1.15 is out, 1.13 becomes unsupported). Instead of hardcoding golang versions, let's specify "stable" and "oldstable" (which currently equals to 1.14.x and 1.13.x). This way, we'll be sure we're testing stuff using up to date and supported golang releases. This was not possible before due to: - travis-ci/gimme#179 - travis-ci/gimme#185 but apparently it's finally fixed. Hooray! Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Aug 1, 2020
Contributor
Author
|
So, $ go version
go version go1.14.6 linux/amd64and $ go version
go version go1.13.14 linux/amd64so I guess we're good! |
I have noticed that `go vet` from golang 1.13 ignores the vendor/ subdir, downloading all the modules when invoked in Travis CI env. As the other go commands, in 1.13 it needs explicit -mod=vendor flag, so let's provide one. PS once golang 1.13 is unsupported, we will drop it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@thaJeztah PTAL |
Member
|
I'm not sure we want this. I think we want to be aware of the tested versions explicitly. |
Member
|
Yeah, not a fan; I generally prefer explicit > implicit as well; even if that means a PR to update twice a year |
Contributor
|
I agree with @thaJeztah and @AkihiroSuda here |
Member
|
@kolyshkin btw |
Contributor
Author
|
Closing as per comments above. The Makefile fix is separated out to #2545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golang is supporting two minor releases (currently 1.14.x and 1.13.x),
and thus once a new minor release is out, the oldest supported one
becomes unsupported (e.g. when 1.15 is out, 1.13 becomes unsupported).
Instead of hardcoding golang versions, let's specify "stable" and
"oldstable" (which currently equals to 1.14.x and 1.13.x). This way,
we'll be sure we're testing stuff using up to date and supported golang
releases.
This was not possible before due to:
but apparently it's finally fixed. Hooray!
Previous discussion on the topic:
Also, add
-mod=vendortogo fmtandgo vetsince it's requiredfor go 1.13 to honor vendor subdir. This should speed up CI a little bit.