Libcontainer: refactor capabilities code and remove RHEL6 workaround#2595
Merged
AkihiroSuda merged 5 commits intoSep 29, 2020
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was a workaround for RHEL6 (2.6.xx) kernels, which have not been supported by container runtimes for a long time, so should be safe to remove this workaround. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
Member
Author
|
@kolyshkin @mrunalp ptal |
Member
|
Can we update the README to clarify the current minimum kernel requirement? 3.10? (Does it work without Red Hat patches?) |
Member
Author
|
I don't think we test 3.10.x on anything other than RHEL 7 / CentOS 7 kernels. Not sure if there's still uses of runc on Debian Jessie (3.16); I know that kernel was somewhat problematic at some point. Perhaps we should be explicit on the intent; something along the lines of "Runc support kernel 3.10 to facilitate RHEL7 and CentOS7. For other distributions, we recommend/support kernel 4.0 and up" |
Member
Author
|
FWIW; I'd be ok with keeping the RHEL6 hack if it's a concern (removing it is just a minor cleanup, so I'm not strongly attached to removing it) |
Contributor
|
@AkihiroSuda @mrunalp PTAL |
AkihiroSuda
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details