ci: pin shfmt to v3.2.0#2671
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Nov 6, 2020
Merged
Conversation
AkihiroSuda
previously approved these changes
Nov 4, 2020
mrunalp
previously approved these changes
Nov 4, 2020
Contributor
|
nit: commit title |
AkihiroSuda
previously approved these changes
Nov 4, 2020
mrunalp
previously approved these changes
Nov 4, 2020
mrunalp
previously approved these changes
Nov 4, 2020
We had to use shfmt from git master/HEAD in commit 069fddf as at the time there was no released/tagged version that supports bats syntax. Now there is (https://github.com/mvdan/sh/releases/tag/v3.2.0), so let's pin it to avoid sudden regressions caused by changes in master branch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@mrunalp @AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Nov 5, 2020
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM. I'm not a huge fan of cd ~ && GO111MODULE=on stuff, but I can't come up with a better alternative.
Contributor
Author
Me neither :( this is just a peculiarity of golang, and I hate to do something like |
mrunalp
approved these changes
Nov 6, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to use shfmt from git master/HEAD in commit 069fddf as at the
time there was no released/tagged version that supports bats syntax.
Now there is (https://github.com/mvdan/sh/releases/tag/v3.2.0),
so let's pin it to avoid sudden regressions caused by changes in master
branch.