More GitHub actions#2687
Merged
Merged
Conversation
kolyshkin
force-pushed
the
more-github-actions
branch
8 times, most recently
from
6b5f9cf to
adf373a
Compare
kolyshkin
force-pushed
the
more-github-actions
branch
7 times, most recently
from
bc0e46b to
ea78e8b
Compare
This serves two purposes: 1. A developer can now run `make shfmt` to show and fix any issues with shell or bats files formatting (this requires a recent version of shfmt, which I think is out of scope for Makefile). 2. Exclude shfmt check from travis ci (will be re-added as a GH action by the next commit). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
...so we can add more validation-type jobs. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This serves two purposes: 1. A developer can now run `make shellcheck` to show any issues with shell or bats files formatting (this requires a recent version of shfmt, which I think is out of scope for Makefile). 2. Exclude shellcheck from travis ci (will be re-added as a GH action by the next commit). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Note that 1. No golang caching is required, since we do not build any go code, and it does not look like it make sense to cache a single binary we donwload from github. 2. Use a problem matcher, so the PRs will be annotated with shellcheck warnings. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
more-github-actions
branch
from
ea78e8b to
c6ed185
Compare
Contributor
Author
|
@AkihiroSuda @mrunalp PTAL |
AkihiroSuda
approved these changes
Nov 24, 2020
mrunalp
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves a few checks from Travis to github actions.