Skip to content

libctl/cgroups/fscommon: close fd#2710

Merged
kolyshkin merged 1 commit into
opencontainers:masterfrom
Creatone:creatone/fscommon-close-fd
Dec 18, 2020
Merged

libctl/cgroups/fscommon: close fd#2710
kolyshkin merged 1 commit into
opencontainers:masterfrom
Creatone:creatone/fscommon-close-fd

Conversation

@Creatone
Copy link
Copy Markdown

A file descriptor should be closed after reading.

Signed-off-by: Paweł Szulik pawel.szulik@intel.com

Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

looks like this was introduced in #2635

/cc @kolyshkin

Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you for catching this.

@kolyshkin kolyshkin merged commit 77b5d8a into opencontainers:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants