libcontainer: signalAllProcesses(): log warning when failing to thaw#2722
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Jan 14, 2021
Merged
libcontainer: signalAllProcesses(): log warning when failing to thaw#2722mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
I noticed this was the only place in this function where we didn't handle errors on freezing/thawing. Logging as a warning, consistent with the other cases. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@kolyshkin @AkihiroSuda ptal |
Contributor
|
CI (fedora) got stuck and hit a timeout. Restarted. |
Contributor
Member
Author
|
All green now! Thanks for restarting CI |
mrunalp
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this was the only place in this function where we didn't handle errors on freezing/thawing. Logging as a warning, consistent with the other cases.