script/check-config.sh: fixes for cgroupv2 and v5.x kernels#2729
Merged
Conversation
kolyshkin
force-pushed
the
check-config
branch
2 times, most recently
from
1fe94e3 to
85a687e
Compare
tianon
reviewed
Jan 11, 2021
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Generally LGTM, just one minor nit 👍 ❤️
| cgroupDir="$(dirname "$cgroupSubsystemDir")" | ||
| if [ -d "$cgroupDir/cpu" -o -d "$cgroupDir/cpuacct" -o -d "$cgroupDir/cpuset" -o -d "$cgroupDir/devices" -o -d "$cgroupDir/freezer" -o -d "$cgroupDir/memory" ]; then | ||
| echo "$(wrap_good 'cgroup hierarchy' 'properly mounted') [$cgroupDir]" | ||
| if [[ $(stat -f -c %t /sys/fs/cgroup 2>/dev/null) = "63677270" ]]; then |
Member
There was a problem hiding this comment.
[[ isn't necessary here; technically we should do $() in a separate command to catch the failure, but in this case we don't actually care about the failure (and the else should cover it) so it's fine:
Suggested change
| if [[ $(stat -f -c %t /sys/fs/cgroup 2>/dev/null) = "63677270" ]]; then | |
| if [ "$(stat -f -c %t /sys/fs/cgroup 2>/dev/null)" = '63677270' ]; then |
Contributor
Author
There was a problem hiding this comment.
Thanks, makes sense (I am unsure why I used [[ in the first place).
Fixed.
Member
|
(Sorry, saw |
Before: > Generally Necessary: > - cgroup hierarchy: nonexistent?? > (see https://github.com/tianon/cgroupfs-mount) After: > Generally Necessary: > - cgroup hierarchy: cgroupv2 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
CONFIG_NF_NAT_IPV4 was removed in kernel commit 3bf195ae6037e310, which made its way into v5.1-rc1. The functionality is now under NF_NAT which we already check for. Make the check for NF_NAT_IPV4 conditional. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
CONFIG_NF_NAT_NEEDED was removed in kernel commit 4806e975729f99c7, which made its way into v5.2-rc1. The functionality is now under NF_NAT which we already check for. Make the check for NF_NAT_NEEDED conditional. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Kernel commit 2d1c498072de69e (which made its way into kernel v5.8-rc1) removed CONFIG_MEMCG_SWAP_ENABLED Kconfig option, making swap accounting always enabled (unless swapaccount=0 boot option is provided). Make the check conditional. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
These config options are removed by kernel commit f382fb0bcef4, which made its way into kernel v5.0-rc1. Make the check conditional. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
check-config
branch
from
85a687e to
b3cf483
Compare
Contributor
Author
AkihiroSuda
reviewed
Jan 13, 2021
| if [ -d "$cgroupDir/cpu" -o -d "$cgroupDir/cpuacct" -o -d "$cgroupDir/cpuset" -o -d "$cgroupDir/devices" -o -d "$cgroupDir/freezer" -o -d "$cgroupDir/memory" ]; then | ||
| echo "$(wrap_good 'cgroup hierarchy' 'properly mounted') [$cgroupDir]" | ||
| if [ "$(stat -f -c %t /sys/fs/cgroup 2>/dev/null)" = "63677270" ]; then | ||
| echo "$(wrap_good 'cgroup hierarchy' 'cgroupv2')" |
Member
There was a problem hiding this comment.
I think we need more validations for cgroup2, but it can be worked out later, so LGTM
AkihiroSuda
approved these changes
Jan 13, 2021
mrunalp
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes script/check-config.sh to
See individual commits for details.