test: unify debian and busybox image setup#2764
Closed
zhsj wants to merge 1 commit intoopencontainers:masterfrom
Closed
test: unify debian and busybox image setup#2764zhsj wants to merge 1 commit intoopencontainers:masterfrom
zhsj wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Like busybox image, download debian rootfs from GitHub. Signed-off-by: Shengjing Zhu <zhsj@debian.org>
AkihiroSuda
approved these changes
Jan 25, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM.
We should error out when $(go env GOARCH) != amd64 && $(go env GOARCH) != amd64, but the issue is not new in this PR and can be fixed later.
Member
|
Lots of overlap here with #2741 😅 |
Contributor
Author
|
close in favor of #2741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like busybox image, download debian rootfs from GitHub.