libcontainer/factory*: adjust the file mode#2829
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Mar 4, 2021
Merged
libcontainer/factory*: adjust the file mode#2829mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
This commit adjusts the file mode to use the latest golang style Related to opencontainers#2625 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
Contributor
|
CI failure on Fedora is unrelated (#2805); restarted CI |
kolyshkin
approved these changes
Mar 2, 2021
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
This is purely cosmetical, but LGTM
mrunalp
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adjusts the file mode to use the latest golang style
Related to #2625
BTW, I think we should not only modify the file mode from the old style to the latest style but also check whether the current implementation sets proper file permissions.
So, I will create the PRs each subsystem or codes and I may create the new issue to summarize this activity.
Signed-off-by: Kenta Tada Kenta.Tada@sony.com