libcontainer/apparmor: use sync.Once for AppArmor detection#2852
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Mar 21, 2021
Merged
libcontainer/apparmor: use sync.Once for AppArmor detection#2852AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
AkihiroSuda
previously approved these changes
Mar 15, 2021
kolyshkin
reviewed
Mar 15, 2021
| ) | ||
|
|
||
| var ( | ||
| appArmorSupported bool |
Contributor
There was a problem hiding this comment.
nit: s/Supported/Enabled/
Member
Author
There was a problem hiding this comment.
Dang! I looked at it and wanted to update, but forgot: done 👍
Contributor
|
A nit, LGTM otherwise |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
apparmor_once
branch
from
e864338 to
a608b7e
Compare
Contributor
|
CI failure is a flake (#2760 (comment)), CI restarted. |
Contributor
Contributor
|
This PR appears to be a champion in the amount of unrelated CI failures. CI restarted |
Member
Author
I opened this PR to reveal flaky tests 🤣😂 |
AkihiroSuda
approved these changes
Mar 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recalled I added a similar change in containerd, but didn't upstream it here. Also removing
bytes.HasPrefix()in favor of just checking the first character