.cirrus.yml: simplify for centos, retry yum#3153
Merged
thaJeztah merged 2 commits intoopencontainers:masterfrom Aug 17, 2021
Merged
.cirrus.yml: simplify for centos, retry yum#3153thaJeztah merged 2 commits intoopencontainers:masterfrom
thaJeztah merged 2 commits intoopencontainers:masterfrom
Conversation
kolyshkin
force-pushed
the
cirrus-robust
branch
from
e84bebf to
6c5eff4
Compare
Contributor
Author
|
Ahhh
Seems that powertools repo is not enabled 👎🏻 |
GCP images description at [1] claims that: - For CentOS 8 and CentOS Stream 8, the PowerTools repository is enabled. - For CentOS 7, EPEL is enabled. Apparently, - we do not need epel for centos-stream-8; - powertools is not enabled on centos-stream-8 despite [1]. Anyway, the less yum commands the better, as we have seen those fail sometimes due to occasional networking problems etc. [1] https://cloud.google.com/compute/docs/images/os-details#centos Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
changed the title
kolyshkin
force-pushed
the
cirrus-robust
branch
from
6c5eff4 to
634e212
Compare
kolyshkin
changed the title
Contributor
Author
|
OK, works as intended, hope to bring down flakes. |
AkihiroSuda
reviewed
Aug 12, 2021
| # Work around dnf mirror failures by retrying a few times. | ||
| for i in $(seq 0 2); do | ||
| sleep $i | ||
| yum install -y -q gcc git iptables jq glibc-static libseccomp-devel make criu && break |
Member
There was a problem hiding this comment.
We should make sure to fail here when yum failed on i==2
Contributor
Author
There was a problem hiding this comment.
Assuming the script is run with set -e, it will fail if yum fails on the last iteration. In case -e is not set, well, we have to add it to all scripts.
Contributor
Author
There was a problem hiding this comment.
Yes, it's run with set -e. Yes we need to check exit code after for 🤦🏻
Thanks for catching this! Fixed, PTAL.
Add a sleep + retry loop in case yum install has failed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
cirrus-robust
branch
from
634e212 to
f0dbefa
Compare
AkihiroSuda
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this PR is CI fails on yum sometimes (seen twice today, last time at #3151 (comment)).
See individual commits for details.