Fix conversion of sysctl variable dots and slashes#3257
Merged
kolyshkin merged 2 commits intoopencontainers:masterfrom Nov 5, 2021
Merged
Fix conversion of sysctl variable dots and slashes#3257kolyshkin merged 2 commits intoopencontainers:masterfrom
kolyshkin merged 2 commits intoopencontainers:masterfrom
Conversation
2818710 to
5f5a55d
Compare
Author
|
PTAL @AkihiroSuda @mrunalp |
AkihiroSuda
reviewed
Nov 1, 2021
5f5a55d to
80e8284
Compare
AkihiroSuda
previously approved these changes
Nov 1, 2021
This was referenced Nov 2, 2021
kolyshkin
requested changes
Nov 3, 2021
Contributor
kolyshkin
left a comment
There was a problem hiding this comment.
Left some nits.
Can you please separate out the package validate_test -> package validate change to a separate (first) commit?
80e8284 to
f317f87
Compare
kolyshkin
reviewed
Nov 4, 2021
Contributor
|
LGTM except for a single nit, thank you @mengjiao-liu! Also, this needs to be rebased due to #3261 |
Contributor
|
Ah, and the signed-off-by needs to be added to the commits (see https://github.com/opencontainers/runc/pull/3257/checks?check_run_id=4100751081) |
f317f87 to
d6ddce7
Compare
added 2 commits
November 4, 2021 11:45
Signed-off-by: Mengjiao Liu <mengjiao.liu@daocloud.io>
Signed-off-by: Mengjiao Liu <mengjiao.liu@daocloud.io>
d6ddce7 to
a9bb11e
Compare
Author
|
Rebased and signed-off-by. Thanks for reminding! |
AkihiroSuda
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #3256
see
sysctl conversion function according to the linux sysctl conversion definition.
see following webpages for more details:
https://man7.org/linux/man-pages/man8/sysctl.8.html
https://man7.org/linux/man-pages/man5/sysctl.d.5.html
Related to: