libct/intelrdt: explain why mountinfo is required#3339
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Jan 24, 2022
Merged
libct/intelrdt: explain why mountinfo is required#3339AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
Member
|
#3306 was merged; looks like this can be rebased and moved out of draft |
For the Nth time I wanted to replace parsing mountinfo with statfs and the check for superblock magic, but it is not possible since some code relies of mount options check which can only be obtained via mountinfo. Add a note about it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
rtd-faster-followup
branch
from
f585d4f to
5e201e7
Compare
Contributor
Author
|
rebased; no longer a draft |
AkihiroSuda
approved these changes
Jan 24, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Nth time I wanted to replace parsing mountinfo with
statfs and the check for superblock magic, but it is not possible
since some code relies of mount options check which can only
be obtained via mountinfo.
Add a note about it.
Currently a draft, pending #3306 merge.