libct/cg/sd: optimize and test findDeviceGroup#3357
Merged
thaJeztah merged 1 commit intoopencontainers:mainfrom Apr 27, 2023
Merged
libct/cg/sd: optimize and test findDeviceGroup#3357thaJeztah merged 1 commit intoopencontainers:mainfrom
thaJeztah merged 1 commit intoopencontainers:mainfrom
Conversation
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
2 times, most recently
from
ddccea2 to
94e14c8
Compare
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
94e14c8 to
bdd51d9
Compare
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
bdd51d9 to
c12d83f
Compare
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
c12d83f to
ed71681
Compare
Contributor
Author
|
Rebased, dropped the commit which contained optimization which did not resulted in any noticeable improvement. @cyphar @thaJeztah PTAL |
kolyshkin
changed the title
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
ed71681 to
63e5028
Compare
Contributor
Author
|
@thaJeztah sorry to bother you, I have just updated the commit to remove most of bytes-related ugliness. Apparently, in modern Go versions, using bytes instead of strings does not result in any performance gain (it used to be the case, but appears to be fixed now). The performance gain (and drastically reduced number of allocations) comes from ditching fmt.Sscanf which is apparently not implemented very well. The new patch is much smaller and focused, PTAL. |
Member
|
Oh! Interesting that they improved that; good to know! |
Contributor
Author
|
@AkihiroSuda @cyphar PTAL |
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
63e5028 to
ef886e1
Compare
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
ef886e1 to
d040bf9
Compare
Contributor
Author
somehow your LGTM got lost @thaJeztah; PTA(nother)L |
Contributor
Author
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
d040bf9 to
842c131
Compare
Contributor
Author
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
2 times, most recently
from
ed02291 to
06f67e9
Compare
mrunalp
approved these changes
Nov 21, 2022
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
06f67e9 to
1228258
Compare
Contributor
Author
|
@thaJeztah you have previously LGTMed this; PTAAL |
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
1228258 to
a9ed27c
Compare
1. Use strings.TrimPrefix instead of fmt.Sscanf and simplify the code. 2. Add a test case and a benchmark. The benchmark shows some improvement, compared to the old implementation: name old time/op new time/op delta FindDeviceGroup-4 39.7µs ± 2% 26.8µs ± 2% -32.63% (p=0.008 n=5+5) name old alloc/op new alloc/op delta FindDeviceGroup-4 6.08kB ± 0% 4.23kB ± 0% -30.39% (p=0.008 n=5+5) name old allocs/op new allocs/op delta FindDeviceGroup-4 117 ± 0% 6 ± 0% -94.87% (p=0.008 n=5+5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
more-bytes-less-strings
branch
from
a9ed27c to
defb1cc
Compare
Contributor
Author
|
Rebased; @opencontainers/runc-maintainers PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes/depends on #3356, draft until merged.Using strings.TrimPrefix instead of fmt.Sscanf.
Add a test case and a benchmark.
The benchmark shows some improvement, compared to the old
implementation: