libct: rm BaseContainer and Container interfaces#3375
Merged
thaJeztah merged 1 commit intoopencontainers:mainfrom Mar 23, 2022
Merged
libct: rm BaseContainer and Container interfaces#3375thaJeztah merged 1 commit intoopencontainers:mainfrom
thaJeztah merged 1 commit intoopencontainers:mainfrom
Conversation
kolyshkin
force-pushed
the
rm-container-iface
branch
from
c1f399f to
99333b4
Compare
Merged
kolyshkin
force-pushed
the
rm-container-iface
branch
from
99333b4 to
569b7c0
Compare
Member
|
@kolyshkin this one can be rebased (was considering "we should remove those interfaces", then recalled: "we had a PR for that") 😂 |
The only implementation of these is linuxContainer. It does not make sense to have an interface with a single implementation, and we do not foresee other types of containers being added to runc. Remove BaseContainer and Container interfaces, moving their methods documentation to linuxContainer. Rename linuxContainer to Container. Adopt users from using interface to using struct. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
rm-container-iface
branch
from
569b7c0 to
102b8ab
Compare
Contributor
Author
Rebased; no longer a draft; PTAL @thaJeztah @AkihiroSuda 🙏🏻 (I still have one more PR on top of this, #3385) |
AkihiroSuda
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on and currently includes #3373. Draft until that one is merged.The only implementation of
BaseContainerandContainerislinuxContainer. It does not makesense to have an interface with a single implementation, and we do not
foresee other types of containers being added to runc.
Remove
BaseContainerandContainerinterfaces, moving their methodsdocumentation to
linuxContainer.Rename
linuxContainertoContainer.Adopt users from using interface to using struct.
Continuing the spring cleaning started in #3354. Loosely based on parts of #3316.