integration tests: skip criu tests incorrectly#3380
Closed
lifubang wants to merge 1 commit intoopencontainers:mainfrom
Closed
integration tests: skip criu tests incorrectly#3380lifubang wants to merge 1 commit intoopencontainers:mainfrom
lifubang wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Signed-off-by: lifubang <lifubang@acmcoder.com>
Member
Author
|
@kolyshkin How about this one. Now, all criu tests has been skipped in CI in other PR. |
Merged
Contributor
kolyshkin
approved these changes
Mar 10, 2022
Contributor
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM; thanks for catching this!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that all criu tests skipped when doing integration tests.
Because
-n "$var"means the length of "$var" should be greater than 0, and-z "$var"means the length of "$var" should equal to 0.I don't know whether skipping all integration tests is your intended thought or not?
Signed-off-by: lifubang lifubang@acmcoder.com