Vagrantfile.fedora: fix build wrt new git#3471
Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom May 12, 2022
Merged
Vagrantfile.fedora: fix build wrt new git#3471AkihiroSuda merged 1 commit intoopencontainers:mainfrom
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
Conversation
With the updated git in Fedora 35, we can't build it via sudo:
ssh default 'sudo -i make -C /vagrant localunittest'
make: Entering directory '/vagrant'
fatal: unsafe repository ('/vagrant' is owned by someone else)
To add an exception for this directory, call:
git config --global --add safe.directory /vagrant
go build -trimpath "-buildmode=pie" -tags "seccomp" -ldflags "-X main.gitCommit= -X main.version=1.1.0+dev " -o runc .
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
make: Leaving directory '/vagrant'
This commit should fix this.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added
area/ci
backport/1.1-todo
Contributor
Author
|
This workaround is kind of dirty, but this is only for CI so I guess it's OK. In case anyone has a better solution, please speak up. |
Contributor
Author
|
1.1 backport: #3472 |
kolyshkin
added
backport/1.1-done
AkihiroSuda
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Fedora CI is broken on all PRs. This is caused by the updated git,
as a result we can no longer build runc via sudo from Vagrant:
This commit should fix this.