ci: shellcheck job nits#3486
Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom Jun 2, 2022
Merged
Conversation
kolyshkin
force-pushed
the
gha-ci-shellcheck
branch
from
5268b50 to
fa1deb8
Compare
1. Use env directive instead of adding to $GITHUB_ENV. 2. Use bash herefile to feed sha256sum instead of pipe to grep. 3. Fix the hardcoded checksum (it was missing the first character). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
gha-ci-shellcheck
branch
from
fa1deb8 to
6b96cbd
Compare
tianon
reviewed
May 26, 2022
Contributor
Author
|
@opencontainers/runc-maintainers PTAL |
AkihiroSuda
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(inspired by script/seccomp.sh: check tarball sha256 #3482 (review))