libcontainer: relax getenv_int sanity check#3489
Merged
thaJeztah merged 1 commit intoopencontainers:mainfrom Jun 1, 2022
Merged
libcontainer: relax getenv_int sanity check#3489thaJeztah merged 1 commit intoopencontainers:mainfrom
thaJeztah merged 1 commit intoopencontainers:mainfrom
Conversation
Contributor
|
LGTM |
kolyshkin
added
the
backport/1.1-todo
Contributor
|
@eriksjolund can you please open a backport of this one to |
eriksjolund
force-pushed
the
relax_sanity_check_in_getenv_int
branch
from
e2de218 to
00af87d
Compare
Contributor
Author
|
Sure.
|
cyphar
previously approved these changes
Jun 1, 2022
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
LGTM. I have no memory of this check. Very strange.
Remove upper bound in integer sanity check to not restrict the number of socket-activated sockets passed in. Closes opencontainers#3488 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
cyphar
force-pushed
the
relax_sanity_check_in_getenv_int
branch
from
00af87d to
03a210d
Compare
kolyshkin
added
backport/1.0-done
Contributor
That was my silly attempt in trying to unify the code that parses the log level with the code that parses the fd value. |
Member
Ah, fair enough -- socket activation is not something we test for very thoroughly so you can't really be blamed for missing that it would break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove upper bound in integer sanity check
to not restrict the number of socket-activated
sockets passed in.
Closes #3488
Signed-off-by: Erik Sjölund erik.sjolund@gmail.com
Is this a correct way to fix the bug? (I am not familiar with runc)