[1.1] cgroups: systemd: skip adding device paths that don't exist#3504
Merged
thaJeztah merged 1 commit intoopencontainers:release-1.1from Jun 8, 2022
cyphar:1.1-systemd-devices-nonexistent-files
Merged
[1.1] cgroups: systemd: skip adding device paths that don't exist#3504thaJeztah merged 1 commit intoopencontainers:release-1.1from cyphar:1.1-systemd-devices-nonexistent-files
thaJeztah merged 1 commit intoopencontainers:release-1.1from
cyphar:1.1-systemd-devices-nonexistent-files
Conversation
kolyshkin
previously approved these changes
Jun 7, 2022
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM given that CI is green
systemd emits very loud warnings when the path specified doesn't exist (which can be the case for some of our default rules). We don't need the ruleset we give systemd to be completely accurate (we discard some kinds of wildcard rules anyway) so we can safely skip adding these. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Contributor
|
@thaJeztah @AkihiroSuda PTAL |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3498.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com