fix: checkpoint error when destroy container#3578
Closed
gosoon wants to merge 2 commits intoopencontainers:mainfrom
Closed
fix: checkpoint error when destroy container#3578gosoon wants to merge 2 commits intoopencontainers:mainfrom
gosoon wants to merge 2 commits intoopencontainers:mainfrom
Conversation
Signed-off-by: gosoon <tianfeiyu0@gmail.com>
kolyshkin
reviewed
Aug 29, 2022
| // destroy container unless we tell CRIU to keep it | ||
| defer destroy(container) | ||
| defer func() { | ||
| if err := killContainer(container); err != nil { |
Contributor
There was a problem hiding this comment.
I don't understand this change. What destroy does is removing the container. What killContainer does is sending SIGKILL to the container. Replacing one with the other does not make sense.
I don't understand how it fixes #3577 either.
Contributor
|
@gosoon PTAL ^^^ |
Contributor
|
@gosoon I left a question above. Your patch comes without an explanation. Can you please describe/explain why this change is needed, what it does, etc. |
Contributor
|
OK, I took a look and it seems that destroy() should not be called at all if the checkpointing failed. Here's a PR: #3655 |
Contributor
|
Superceded by #3655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue#3577