libct/seccomp/patchbpf: rm duplicated code#3635
Merged
cyphar merged 1 commit intoopencontainers:mainfrom Nov 2, 2022
Merged
Conversation
kolyshkin
force-pushed
the
ebpf-dup-code
branch
from
cb2bc6a to
3eff108
Compare
Contributor
Author
|
@thaJeztah PTAL |
Contributor
Author
|
@thaJeztah @AkihiroSuda PTAL |
thaJeztah
approved these changes
Nov 1, 2022
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
thanks for the ping, was reading it from my phone last week, and wanted to check on my computer 😂
In findLastSyscalls, we convert libseccomp.ArchNative to the real libseccomp architecture, but archToNative already does that, so this code is redundant. Remove the redundant code, and move its comment to archToNative. Fixes: 7a8d716 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
ebpf-dup-code
branch
from
3eff108 to
2cd05e4
Compare
kolyshkin
added
the
backport/1.1-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In findLastSyscalls, we convert libseccomp.ArchNative to the real libseccomp architecture, but archToNative already does that, so this code is redundant.
Remove the redundant code, and move its comment to archToNative.
Fixes: 7a8d716