tests: Fix weird error on centos-9#3740
Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom Feb 11, 2023
Merged
Conversation
Member
Author
|
I think this should do the trick (if sleep command there has the infinity option, unsure if all distros have it). But let's see... I'm pushing this commit to other open PRs I have, to run it more times |
d1a72f8 to
8e4df13
Compare
Member
Author
|
Pushing to foce it to run again |
Member
Author
|
Well, that seems fixed but there is yet another issue, now in integration tests: Opened another issue for that one :( |
centos-9 unit test sometimes fails with: === RUN TestPodSkipDevicesUpdate systemd_test.go:114: container stderr not empty: basename: missing operand Try 'basename --help' for more information. --- FAIL: TestPodSkipDevicesUpdate (0.11s) I'm not sure why the container output is an error in basename. It seems likely that the bashrc in that distro is kind of broken. Let's just run a sleep command and forget about bash. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
8e4df13 to
4d0a60c
Compare
Member
Author
|
All green now! |
AkihiroSuda
approved these changes
Feb 11, 2023
Contributor
|
Backported to 1.1 in #3791 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
centos-9 unit test sometimes fails with:
I'm not sure why the container output is an error in basename. It seems
likely that the bashrc in that distro is kind of broken. Let's just run
a sleep command and forget about bash.
Fixes: #3742
Signed-off-by: Rodrigo Campos rodrigoca@microsoft.com