ci/gha: disable double caching#3822
Merged
kolyshkin merged 2 commits intoopencontainers:mainfrom May 16, 2023
Merged
Conversation
kolyshkin
changed the title
AkihiroSuda
approved these changes
Apr 14, 2023
Contributor
Author
|
@thaJeztah PTAL |
austinvazquez
approved these changes
May 3, 2023
thaJeztah
reviewed
May 3, 2023
| ~/go/pkg/mod | ||
| ~/.cache/go-build | ||
| key: ${{ runner.os }}-go.sum-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: ${{ runner.os }}-go.sum- |
Member
There was a problem hiding this comment.
The issue with CGO caching was resolved?
Contributor
Author
There was a problem hiding this comment.
It is irrelevant to this PR for two reasons:
- We remove own caching here, which is sort of orthogonal to that issue
- We only validate the dependencies here, and the issue (cache key do not include linux distro name and version actions/setup-go#368; which is not yet fixed) only surfaces when we use different distros at the same time (which we don't do here).
Contributor
Author
There was a problem hiding this comment.
(and when we use different distros at the same time and are affected, we disable caching:
runc/.github/workflows/test.yml
Line 70 in 2685116
thaJeztah
approved these changes
May 3, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (if the issue with CGO is resolved)
Since commit e3cf217 actions/setup-go@v4 uses caching implicitly, so it is no longer required. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since commit e3cf217 actions/setup-go@v4 uses caching implicitly, and olangci/golangci-lint-action also uses caching. These two caches clash, resulting in multiple warnings in CI logs. The official golangci-lint-action solution is to disable caching for setup-go job (see [1]). Do the same. [1] golangci/golangci-lint-action#704 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit e3cf217 (#3771) actions/setup-go@v4 uses caching implicitly.
Fix two cases of double caching.