tests/int: increase num retries for oom tests#3874
Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom Jun 8, 2023
Merged
tests/int: increase num retries for oom tests#3874kolyshkin merged 1 commit intoopencontainers:mainfrom
kolyshkin merged 1 commit intoopencontainers:mainfrom
Conversation
AkihiroSuda
approved these changes
May 19, 2023
kolyshkin
force-pushed
the
fix-cs9-oom
branch
4 times, most recently
from
d8f95ab to
1a0fc2d
Compare
Contributor
Author
|
Run this tests a lot of times on centos-stream-9 CI, it also finishes in 6-7 seconds. So, I am not convinved that increasing the timeout helps, but it won't hurt either. |
Contributor
Author
|
CI failure on Fedora is unrelated; opened #3880 to fix. |
thaJeztah
approved these changes
May 30, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM
but let me know if this was indeed the right thing (I see you commented above)
This test is occasionally failing on CS9. The test case always takes about 7 seconds on my laptop (decreasing memory, using a different memory eater in shell etc. doesn't help). Increase the number of iterations from 10 to 30 to make sure we don't see any flakes. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added
the
backport/1.1-todo
kolyshkin
added
backport/1.1-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is occasionally failing on CS9.
The test case always takes about 7 seconds on my laptop (decreasing
memory, using a different memory eater in shell etc. doesn't help).
Increase the number of iterations from 10 to 30 to make sure we don't
see any flakes.
Fixes: #3868