[1.1] Fix some file mode bits missing when doing mount syscall#3961
Merged
kolyshkin merged 2 commits intoopencontainers:release-1.1from Aug 3, 2023
Merged
[1.1] Fix some file mode bits missing when doing mount syscall#3961kolyshkin merged 2 commits intoopencontainers:release-1.1from
kolyshkin merged 2 commits intoopencontainers:release-1.1from
Conversation
kolyshkin
referenced
this pull request
Aug 10, 2023
When a directory already exists (or after a container is restarted) the perms of the directory being mounted to were being used even when a different permission is set on the tmpfs mount options. This prepends the original directory perms to the mount options. If the perms were already set in the mount opts then those perms will win. This eliminates the need to perform a chmod after mount entirely. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This the backport of #3956 to
release-1.1, the original description is:Fix #3952
When we call
unix.Mount, if we use file mode bits from the bits with the typefs.FileModedirectly, it will cause some bits missing.Please refer: https://github.com/golang/go/blob/master/src/os/file.go#L258-L265
More details: https://www.gnu.org/software/coreutils/manual/html_node/Mode-Structure.html