Skip to content

[1.1] ci/gha: fix downloading Release.key#4081

Merged
cyphar merged 1 commit intoopencontainers:release-1.1from
kolyshkin:1.1-4079
Oct 20, 2023
Merged

[1.1] ci/gha: fix downloading Release.key#4081
cyphar merged 1 commit intoopencontainers:release-1.1from
kolyshkin:1.1-4079

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

This is a backport of #4079 to release-1.1 branch.

Since today, the URL from download.opensuse.org started returning a HTTP 302 redirect, so -L option for curl is needed to follow it.

While at it, remove apt-key as per its man page recommendation:

Note: Instead of using this command a keyring should be placed
directly in the /etc/apt/trusted.gpg.d/ directory with a descriptive
name and either "gpg" or "asc" as file extension.

Since today, the URL from download.opensuse.org started returning a
HTTP 302 redirect, so -L option for curl is needed to follow it.

While at it, remove apt-key as per its man page recommendation:

> Note: Instead of using this command a keyring should be placed
> directly in the /etc/apt/trusted.gpg.d/ directory with a descriptive
> name and either "gpg" or "asc" as file extension.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit f944d7b)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added area/ci backport/1.1-pr A backport PR to release-1.1 labels Oct 20, 2023
@kolyshkin kolyshkin added this to the 1.1.10 milestone Oct 20, 2023
Copy link
Copy Markdown
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar cyphar merged commit 5ba0e01 into opencontainers:release-1.1 Oct 20, 2023
@kolyshkin kolyshkin mentioned this pull request Oct 24, 2023
@cyphar cyphar mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport/1.1-pr A backport PR to release-1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants