Move test helper binaries#4383
Merged
Merged
Conversation
kolyshkin
force-pushed
the
test-cmd
branch
2 times, most recently
from
3894675 to
23cfc7d
Compare
kolyshkin
requested review from
AkihiroSuda,
cyphar and
rata
and removed request for
AkihiroSuda and
rata
AkihiroSuda
approved these changes
Dec 3, 2024
lifubang
reviewed
Dec 9, 2024
| PIDFD_KILL="${INTEGRATION_ROOT}/../../tests/cmd/pidfd-kill/pidfd-kill" | ||
| REMAP_ROOTFS="${INTEGRATION_ROOT}/../../tests/cmd/remap-rootfs/remap-rootfs" | ||
|
|
||
| # Path to binaries compiled from packages in tests/cmd by "make test-helpers"). |
Member
There was a problem hiding this comment.
:s/make test-helpers/make test-binaries/
Instead of having every test helper binary in its own directory, let's use /tests/cmd/_bin as a destination directory. This allows for simpler setup/cleanup. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #4377, originally inspired by this comment.
Instead of having every test helper binary in its own directory, let's use
tests/cmd/binas a destination for all of them.This allows for simpler setup/cleanup.