Skip to content

Remove redundant function (needs Go >= 1.23)#4387

Closed
BooleanCat wants to merge 1 commit into
opencontainers:mainfrom
BooleanCat:main
Closed

Remove redundant function (needs Go >= 1.23)#4387
BooleanCat wants to merge 1 commit into
opencontainers:mainfrom
BooleanCat:main

Conversation

@BooleanCat
Copy link
Copy Markdown

Make use of Go 1.23's news maps and slices iterators to replace a hand-crafted map key sorter.

This relies on Go 1.23 being the minimum version - once it's updaded in go.mod I'll modify this commit to remove my change to go.mod.

Signed-off-by: Tom Godkin <tomgodkin@pm.me>
@BooleanCat
Copy link
Copy Markdown
Author

I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous)

@AkihiroSuda
Copy link
Copy Markdown
Member

I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous)

Yes, so we still have to support Go 1.22

@BooleanCat
Copy link
Copy Markdown
Author

@AkihiroSuda understood, I'll leave this open until 1.24 or if you want to close I'll open another when it's released.

@AkihiroSuda AkihiroSuda marked this pull request as draft August 30, 2024 09:51
@AkihiroSuda AkihiroSuda changed the title Remove redundant function Remove redundant function (needs Go >= 1.23) Aug 30, 2024
octavio12345300

This comment was marked as spam.

@AkihiroSuda
Copy link
Copy Markdown
Member

Needs rebase

@kolyshkin
Copy link
Copy Markdown
Contributor

@BooleanCat this needs a rebase. Please let us know if you want to keep working on this

@kolyshkin
Copy link
Copy Markdown
Contributor

kolyshkin commented Dec 2, 2025

Ah! This is actually obsoleted by commit 370733b (PR #4687), thus closing.

@kolyshkin kolyshkin closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants