add a test for runc exec --cap#4406
Closed
lifubang wants to merge 1 commit into
Closed
Conversation
Signed-off-by: lifubang <lifubang@acmcoder.com>
AkihiroSuda
reviewed
Sep 19, 2024
| [[ "${output}" == *"CapBnd: 0000000400000021"* ]] | ||
| [[ "${output}" == *"CapEff: 0000000000000021"* ]] | ||
| [[ "${output}" == *"CapPrm: 0000000000000021"* ]] | ||
| [[ "${output}" == *"CapAmb: 0000000000000001"* ]] |
Member
There was a problem hiding this comment.
Maybe add comments to help understanding these bitmasks
Member
Author
There was a problem hiding this comment.
OK, I'll add them later.
AkihiroSuda
approved these changes
Sep 19, 2024
kolyshkin
reviewed
Sep 24, 2024
| update_config '.process.capabilities.inheritable = ["CAP_CHOWN", "CAP_SYSLOG"]' | ||
| update_config '.process.capabilities.ambient = ["CAP_CHOWN"]' | ||
| __runc run -d test_some_caps | ||
| [ "$status" -eq 0 ] |
Contributor
There was a problem hiding this comment.
You are not checking runc exit code here, because __runc doesn't use bats' run which sets $status.
If you copied this code from some other place -- that place is also wrong.
kolyshkin
requested changes
Sep 24, 2024
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
You need to explain (either in a commit message or in the test itself) what exactly are you checking for.
Contributor
|
I will add this test to #4367. |
rata
dismissed
their stale review
Will be moved to another PR and adjusted to check for the status
Contributor
|
This is now part of #4367. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.