change go minimum version in README by amghazanfari · Pull Request #4416 · opencontainers/runc

amghazanfari · 2024-09-25T12:44:04Z

In the readme there are two statements

the minimum version of go for runc is v1.21
if you use go v1.22 make sure it's newer than 1.22.4 due to a bug

when i use go v1.21 in Dockerfile for testing I got error

+ exec make localunittest TESTFLAGS=
rm -f libcontainer/dmz/binary/runc-dmz
go generate -tags "seccomp urfave_cli_no_docs" ./libcontainer/dmz
go: go.mod requires go >= 1.22 (running go 1.21.13; GOTOOLCHAIN=local)
make: *** [Makefile:116: runc-dmz] Error 1
make: *** [Makefile:161: unittest] Error 2

but with go v1.22 and v1.23 it was ok. so i change minimum version to 1.22.4 and delete the warning

kolyshkin

My bad; PR #4360 should have done that.

kolyshkin · 2024-09-25T22:30:58Z

-#### Go
-
-NOTE: if building with Go 1.22.x, make sure to use 1.22.4 or a later version
-(see [issue #4233](https://github.com/opencontainers/runc/issues/4233) for
-more details).
-


To other reviewers: this is no longer needed since PR #4407.

Should i change 1.22.4 to 1.22 in my changes?

IMHO just removing this is fine. I think @kolyshkin was just giving context to other reviewers on why removing that note seems fine.

kolyshkin · 2024-09-26T04:39:31Z

~~Apparently actuated removed bats from the default software set, this is why actuated CI fails // Cc @alexellis~~

Nah, there's something wrong with cache restoration logic in actions/bats-setup

lifubang · 2024-09-26T04:43:55Z

Nah, there's something wrong with cache restoration logic in actions/bats-setup

Resolved in #4412

kolyshkin · 2024-09-26T04:46:56Z

Resolved in #4412

Merged, rebased this one.

alexellis · 2024-09-26T07:30:26Z

Hi @kolyshkin nothing has been removed, and bats was never part of the image AFAIK.

Make sure any cache keys you use are unique between actuated/hosted runners as permissions, users and paths may vary - so a cache tar taken from a hosted runner may not restore exactly as expected onto an self-hosted runner and visa-versa.

Let me know if I can help

Calyptia and Fluent both use bats extensively with actuated and I'm not aware of any issues from them. They may not have the cache option enabled for bats?

kolyshkin · 2024-09-26T07:46:15Z

Hi @kolyshkin nothing has been removed, and bats was never part of the image AFAIK.

Make sure any cache keys you use are unique between actuated/hosted runners as permissions, users and paths may vary - so a cache tar taken from a hosted runner may not restore exactly as expected onto an self-hosted runner and visa-versa.

Let me know if I can help

Calyptia and Fluent both use bats extensively with actuated and I'm not aware of any issues from them. They may not have the cache option enabled for bats?

My bad, I mixed things up and mentioned you too early. The issue was in us starting to use https://github.com/bats-core/bats-action, which lacked the arch in cache key, so caches for different archtitectures got mixed. This was promptly reported and fixed by @akhilerm.

Again, thank you so much for allowing runc to use Actuated; it's great and invaluable addition to GitHub Actions.

rata · 2024-09-27T13:09:54Z

 ## Building

-`runc` only supports Linux. It must be built with Go version 1.21 or higher.
+`runc` only supports Linux. It must be built with Go version 1.22.4 or higher.


Now that go enforces the go version in go.mod, don't we want to just delete the last sentence here?

I think it's fine as it is.

rata · 2024-09-27T13:12:24Z

-#### Go
-
-NOTE: if building with Go 1.22.x, make sure to use 1.22.4 or a later version
-(see [issue #4233](https://github.com/opencontainers/runc/issues/4233) for
-more details).
-


IMHO just removing this is fine. I think @kolyshkin was just giving context to other reviewers on why removing that note seems fine.

AkihiroSuda · 2024-09-28T16:22:53Z

Please squash the commits

Signed-off-by: Amir M. Ghazanfari <a.m.ghazanfari76@gmail.com> Update go version Co-authored-by: Akihiro Suda <suda.kyoto@gmail.com> Signed-off-by: Amir M. Ghazanfari <a.m.ghazanfari76@gmail.com>

rata

LGTM, thanks!

rata · 2024-09-30T14:42:09Z

 ## Building

-`runc` only supports Linux. It must be built with Go version 1.21 or higher.
+`runc` only supports Linux. See the header of [`go.mod`](./go mod) for the required Go version.


This was changed. If we are going to have some text, the text before seem better. But I'm fine with this.

@kolyshkin what do you think? You weighted on this before.

kolyshkin

lgtm

kolyshkin approved these changes Sep 25, 2024

View reviewed changes

kolyshkin reviewed Sep 25, 2024

View reviewed changes

kolyshkin force-pushed the change_version branch from d274c2f to f62ec98 Compare September 26, 2024 04:46

rata reviewed Sep 27, 2024

View reviewed changes

AkihiroSuda reviewed Sep 28, 2024

View reviewed changes

Comment thread README.md Outdated

change go minimum version in README

bb2bd38

Signed-off-by: Amir M. Ghazanfari <a.m.ghazanfari76@gmail.com> Update go version Co-authored-by: Akihiro Suda <suda.kyoto@gmail.com> Signed-off-by: Amir M. Ghazanfari <a.m.ghazanfari76@gmail.com>

amghazanfari force-pushed the change_version branch from ac6b145 to bb2bd38 Compare September 29, 2024 19:51

rata approved these changes Sep 30, 2024

View reviewed changes

rata reviewed Sep 30, 2024

View reviewed changes

AkihiroSuda requested a review from kolyshkin October 3, 2024 16:59

AkihiroSuda approved these changes Oct 3, 2024

View reviewed changes

kolyshkin approved these changes Oct 4, 2024

View reviewed changes

kolyshkin merged commit 84529ba into opencontainers:main Oct 4, 2024

Conversation

amghazanfari commented Sep 25, 2024

Uh oh!

kolyshkin left a comment

Choose a reason for hiding this comment

Uh oh!

kolyshkin Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

amghazanfari Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

rata Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

kolyshkin commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lifubang commented Sep 26, 2024

Uh oh!

kolyshkin commented Sep 26, 2024

Uh oh!

alexellis commented Sep 26, 2024

Uh oh!

kolyshkin commented Sep 26, 2024

Uh oh!

rata Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

kolyshkin Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

rata Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AkihiroSuda commented Sep 28, 2024

Uh oh!

rata left a comment

Choose a reason for hiding this comment

Uh oh!

rata Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

kolyshkin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kolyshkin commented Sep 26, 2024 •

edited

Loading