Upgrade Cilium's eBPF library version to 0.16#4436
Closed
dims wants to merge 3 commits intoopencontainers:release-1.1from
Closed
Upgrade Cilium's eBPF library version to 0.16#4436dims wants to merge 3 commits intoopencontainers:release-1.1from
dims wants to merge 3 commits intoopencontainers:release-1.1from
Conversation
Signed-off-by: Rafael Roquetto <rafael.roquetto@grafana.com> Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Looking through git blame, this was added by commit 9fac183 aka "Initial commit of runc binary", most probably by mistake. Obviously, a container should not have access to tun/tap device, unless it is explicitly specified in configuration. Now, removing this might create a compatibility issue, but I see no other choice. Aside from the obvious misconfiguration, this should also fix the annoying > Apr 26 03:46:56 foo.bar systemd[1]: Couldn't stat device /dev/char/10:200: No such file or directory messages from systemd on every container start, when runc uses systemd cgroup driver, and the system runs an old (< v240) version of systemd (the message was presumably eliminated by [1]). [1] systemd/systemd@d5aecba Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: lfbzhm <lifubang@acmcoder.com>
kolyshkin
reviewed
Oct 10, 2024
Contributor
Author
|
@kolyshkin just realized the last point (needs 1.21 from the CI logs) and Looks like it's not feasible in the near future :( So the context is that i wanted to check if there is a way to pick up new cilium/ebpf in kubernetes to address cilium/ebpf#1095 which got fixed in cilium/ebpf#1557 I do agree that avoiding the bump is important and this scenario we are facing in kubernetes is not important enough to push for this cherry pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of #4397 to 1.1 release branch.
NOTE: the vendor/ did not apply cleanly, so i had to fix it by running go mod tidy/vendor with an older
go1.18.10version.