[1.2] deps: update to github.com/cyphar/filepath-securejoin@v0.3.5#4550
Merged
lifubang merged 2 commits intoopencontainers:release-1.2from Dec 8, 2024
Merged
[1.2] deps: update to github.com/cyphar/filepath-securejoin@v0.3.5#4550lifubang merged 2 commits intoopencontainers:release-1.2from
lifubang merged 2 commits intoopencontainers:release-1.2from
Conversation
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
(This is a cherry-pick of 2f1b662.) This fixes a regression in use of securejoin.MkdirAll, where multiple runc processes racing to create the same mountpoint in a shared rootfs would result in spurious EEXIST errors. In particular, this regression caused issues with BuildKit. Fixes: dd827f7 ("utils: switch to securejoin.MkdirAllHandle") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Member
|
I think maybe we should update the PR description to say why we need to update deps: update to golang.org/x/sys@v0.28.0? |
Member
Author
|
@lifubang The filepath-securejoin update forces a golang.org/x/sys update. I'll update the description. |
lifubang
approved these changes
Dec 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4549. Note that
github.com/cyphar/filepath-securejoin@v0.3.5includes a dependency update ofgolang.org/x/sys@v0.28.0which I've split into a separate commit.This fixes a regression in use of securejoin.MkdirAll, where multiple
runc processes racing to create the same mountpoint in a shared rootfs
would result in spurious EEXIST errors. In particular, this regression
caused issues with BuildKit.
Fixes: dd827f7 ("utils: switch to securejoin.MkdirAllHandle")
Fixes #4543
Signed-off-by: Aleksa Sarai cyphar@cyphar.com