Skip to content

add timens to default generated config.json#4573

Closed
akhilerm wants to merge 2 commits intoopencontainers:mainfrom
akhilerm:add-time-ns-example
Closed

add timens to default generated config.json#4573
akhilerm wants to merge 2 commits intoopencontainers:mainfrom
akhilerm:add-time-ns-example

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

  • add timens to generated config.json
  • fix tests to account for timens present in default config.json

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@AkihiroSuda
Copy link
Copy Markdown
Member

Why?

@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Jan 1, 2025

Why?

So that the default generated config.json has all the supported namespaces. Also, as per the discussion here

@cyphar
Copy link
Copy Markdown
Member

cyphar commented Jan 2, 2025

Ah, I forgot that the time namespace doesn't allow a container to do settimeofday -- you need to set the time namespace offset at the beginning to do anything useful. This means that a configuration with just a time namespace and no offset doesn't really do anything.

So that the default generated config.json has all the supported namespaces.

The default configuration doesn't include user namespaces, for similar reasons. There is a stronger argument for making user namespaces enabled by default but you can't do that in a generic way.

@kolyshkin
Copy link
Copy Markdown
Contributor

I also think that time namespace is special and should not be enabled by default.

@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Jan 3, 2025

Closing the PR as the consensus is not to enable timens by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants