Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled. |
Sure. It has been cancelled because of timeout. The timeout is happening because one of the bats tests hangs. The output from the test shows the last successful test, if you take a look at a log from a successful run you'll see the next test is |
|
|
Opened #4602 to track this for runc. |
|
Interesting; great digging! Seems like moby may be missing a test-case for this, or at least I recall my test-PR with go 1.24rc1 completed succesfully |
Also, bump golangci-lint to v1.64 (v1.64.2 added Go 1.24 support). NOTE we still use Go 1.23.x for official builds. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Also: 1. Change GO_VERSION to GO_VER_PREFIX, and move the "." from the jq argument to the variable value. It allows to use something like "1.25" to match "1.25rc" etc, but set to "1.24." for now to require a released 1.24.x version. 2. Change PREFIX to URL_PREFIX. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
See commits for details.