Switch to Go 1.25+#5205
Merged
Merged
Conversation
Since switching to Go 1.25 in go.mod, the "detect fd leaks" test fails like this: > not ok 57 runc create[detect fd leak as comprehensively as possible] > # (in test file tests/integration/create.bats, line 76) > # `[ "$violation_found" -eq 0 ]' failed > ... > # Violation: FD 9 -> '/system.slice/runc-test_busybox.scope/cpu.cfs_quota_us' > # Violation: FD 10 -> '/system.slice/runc-test_busybox.scope/cpu.cfs_period_us' > ... This happens because Go 1.25 adds a feature to dynamically set GOMAXPROC based on current CPU quota values. This feature can be disabled by setting GODEBUG=containermaxprocs=0,updatemaxprocs=0 but it is harmless to keep it (except for the above test failure). Add an exception to the test case. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
kolyshkin
added
the
backport/1.5-todo
AkihiroSuda
approved these changes
Mar 31, 2026
kolyshkin
added
backport/1.5-done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.24 is no longer supported.
(this is a carry of #5169 with the additional test fix)