Fix int64 and uint64 type value ranges #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Bartholomew <jpa.bartholomew@gmail.com>
tianon
approved these changes
Jul 31, 2020
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM
(Confirmed that these new values match MAX_UINT64, MIN_INT64, and MAX_INT64.)
thaJeztah
approved these changes
Jul 31, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (not a maintainer)
thanks for contributing!
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1051, making the schema definition for 'int64' and 'uint64' types have the expected ranges:
int64minimum is -2^63int64maximum is 2^63-1uint64maximum is 2^64-1Signed-off-by: John Bartholomew jpa.bartholomew@gmail.com