Deduplicate the field of RootfsPropagation #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two RootfsPropagation fields, one is Linux.RootfsPropagation, the other one is LinuxRuntime.RootfsPropagation. They are duplicated, one of them should be removed. The RootfsPropagation is definitely a runtime specific configuration, so we remove the one of Linux.RootfsPropagation. And the description of it is moved from config-linux.md to runtime-config-linux.md. Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
Contributor
|
LGTM |
Contributor
|
lgtm |
mrunalp
pushed a commit
that referenced
this pull request
Sep 9, 2015
Deduplicate the field of RootfsPropagation
Contributor
Author
|
This pr is missing due to the previous error @vbatts |
Contributor
Author
|
sorry, it is included. weird. |
Member
|
Yeah. For a short time, master was missing this merge, but I've since fixed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two RootfsPropagation fields, one is Linux.RootfsPropagation,
the other one is LinuxRuntime.RootfsPropagation. They are duplicated,
one of them should be removed.
The RootfsPropagation is definitely a runtime specific configuration,
so we remove the one of Linux.RootfsPropagation.
And the description of it is moved from config-linux.md to
runtime-config-linux.md.
Signed-off-by: Lai Jiangshan jiangshanlai@gmail.com