Rewrite LinuxIDMappings #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basicly make the format consistent with others, no semantics change. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
wking
reviewed
Oct 27, 2016
config-linux.md
Outdated
| **`uidMappings`** (array of objects, OPTIONAL) describes the user namespace uid mappings from the host to the container. | ||
| **`gidMappings`** (array of objects, OPTIONAL) describes the user namespace gid mappings from the host to the container. | ||
|
|
||
| The following parameters can be specified: |
Contributor
There was a problem hiding this comment.
I'd rather follow huge page limits with:
Each entry has the following structure:
We use “The following parameters can be specified” for objects (e.g. memory), and while we're not currently consistent, I think it's good to use different wording for parameters in an array entry than we do for parameters on the object itself.
Contributor
Author
There was a problem hiding this comment.
@wking I've push a new commit to make them consistent.
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Contributor
|
Through 4404abf looks good to me.
|
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basicly make the format consistent with others, no
semantics change.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com