Skip to content

Conversation

@jonboulle
Copy link
Contributor

Also s/OpenContainers/OCI/ as used in the image-spec README.

Signed-off-by: Jonathan Boulle jonathanboulle@gmail.com

Also s/OpenContainers/OCI/ as used in the image-spec README.

Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
@caniszczyk
Copy link
Contributor

caniszczyk commented Nov 15, 2016

LGTM

Approved with PullApprove

1 similar comment
@dqminh
Copy link
Contributor

dqminh commented Nov 15, 2016

LGTM

Approved with PullApprove

@dqminh dqminh merged commit d7e87ca into opencontainers:master Nov 15, 2016
@wking
Copy link
Contributor

wking commented Nov 15, 2016

On Mon, Nov 14, 2016 at 05:16:58PM -0800, Chris Aniszczyk wrote:

LGTM

I'm +1 on the change from this PR, but either @caniszczyk should be
added to MAINTAINERS or his vote shouldn't count as one of the
required 2 1, non-author 2, maintainer 3 LGTMs. Or we should
have docs around “you don't actually need two LGTMs for something that
is obviously a trivial fix”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants