runtime: Remove status redefinitions from operations #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
plz rebase |
These states are already defined in the "State" section. There's no need to redefine them in the operation sections. Operation-level redefinitions are dicy anyway, because they imply something testable about the immediately-after-this-operation time, and it's not possible to run race-free tests of that time (e.g. the process could die for other reasons between the successful 'create' call and the 'state' call you made to look for a 'created' status). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
remove-operation-status-redefinition
branch
from
bb429f4 to
2d8d50c
Compare
Contributor
Author
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These states are already defined in the "State" section. There's no need to redefine them in the operation sections.
Operation-level redefinitions are dicy anyway, because they imply something testable about the immediately-after-this-operation time, and it's not possible to run race-free tests of that time (e.g. the process could die for other reasons between the successful
createcall and thestatecall you made to look for acreatedstatus).