tfix: replace setup #822
Merged
tfix: replace setup #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup is a noun, 'set up' is a verb Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
wking
reviewed
May 15, 2017
|
|
||
| Namespaces are specified as an array of entries inside the `namespaces` root field. | ||
| The following parameters can be specified to setup namespaces: | ||
| The following parameters can be specified to set up namespaces: |
Contributor
There was a problem hiding this comment.
I'd prefer we use “configure” in the sub-properties template. Also looking at parameter vs. property vs. field:
$ git describe
v1.0.0-rc5-162-g4aed614
$ git grep -i propert *.md | wc -l
23
$ git grep -i parameter *.md | wc -l
19
$ git grep -i field *.md | wc -l
18
So I'd like a template like:
The following properties can be specified to configure {thing}.
In this case that would be:
The following properties can be specified to configure namespaces:
But this is just me trying to copy-edit for consistency. The lines are clear as they stand, and slightly more clear with just the “setup” → “set up” change.
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup is a noun, 'set up' is a verb
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com