-
Notifications
You must be signed in to change notification settings - Fork 599
Implementations page #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
implementations.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“OCF” → “OCI”.
4d6af80 to
a4645a8
Compare
|
updated. PTAL |
implementations.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra blank line.
|
On Tue, Aug 04, 2015 at 11:01:31AM -0700, Vincent Batts wrote:
I added a few more pedantic comments. But I like this PR, and am fine |
a4645a8 to
55703e1
Compare
|
Updated (again ;-). PTAL |
|
LGTM |
|
Maybe squash :) |
implementations.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just “Implementations” here? The fact that we're talking about this specification should be clear from the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
On Tue, Aug 4, 2015 at 2:48 PM, Mrunal Patel notifications@github.com
wrote:
In implementations.md
#93 (comment):@@ -0,0 +1,13 @@
+# Implementations of Container Specification+1
—
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/93/files#r36226600.
55703e1 to
b249fc7
Compare
|
done On Tue, Aug 4, 2015 at 2:37 PM, Mrunal Patel notifications@github.com
|
|
I newed a issuse to talk about How to do bundle compatibility test? #78 |
|
See also the discussion that lead to this PR (which also has a In case that link dies, or folks want to look up the conversation in Date: Mon, 3 Aug 2015 16:20:04 +0800 |
|
Hi @philips , we are testing docker, rkt (and will test other runtimes which implement appc spec). |
|
LGTM |
b249fc7 to
62cc442
Compare
|
updated. PTAL |
implementations.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph should be re-wrapped to follow #82.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
On Fri, Aug 7, 2015 at 12:15 PM, W. Trevor King notifications@github.com
wrote:
In implementations.md
#93 (comment):@@ -0,0 +1,18 @@
+# Implementations
+
+The following sections link to associated projects, some of which are
+maintained by the OCI and some of which are maintained by external
+organizations. If you know of any associated projects that are not listed
+here, please file a pull request adding a link to that project.This paragraph should be re-wrapped to follow #82
#82.—
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/93/files#r36534450.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* runc * runv - https://groups.google.com/a/opencontainers.org/d/msg/dev/Tjq5QJ_eez0/LMt3dgReDQAJ * ocp-testing - https://groups.google.com/a/opencontainers.org/d/msg/dev/_XUjuKzL84g/i2n5s0iUBgAJ Signed-off-by: Vincent Batts <vbatts@redhat.com>
62cc442 to
b3ebf84
Compare
|
LGTM |
1 similar comment
|
LGTM |
Adding an implementations page.