runtime: support oomScoreAdj validation #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
| return fmt.Errorf("oomScoreAdj expected: %v, actual: %v", expected, actual) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
What happens if oomScoreAdj is null or unset? Do we require particular runtime behavior in that case? I'd expect we require the runtime to leave the setting alone, although the current spec doesn't spell that out.
Contributor
Contributor
|
LGTM |
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 13, 2016
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from 3d2cac7 opencontainers#210 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 15, 2016
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from 3d2cac7 opencontainers#210 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com