validate/validate: Linux rlimits extend the POSIX rlimits #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So don't duplicate those values. Also drop RLIMIT_LOCKS, which the man page documents as an obsolete-by-Linux-2.6 value [1]. A quick way to get a set of strings from the man page is: $ curl -s 'https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/plain/man2/getrlimit.2?h=man-pages-4.13' | > sed -n 's/^\.BR\? \(RLIMIT_[^ ]*\)/\1/p' | sort | uniq Also rename the old default*Rlimits, because these are valid-value arrays, not defaults. [1]: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/man2/getrlimit.2?h=man-pages-4.13#n209 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
linux-rlimits-extend-posix-rlimits
branch
from
aff40e1 to
894cae7
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So don't duplicate those values. Also drop
RLIMIT_LOCKS, which the man page documents as an obsolete-by-Linux-2.6 value. A quick way to get a set of strings from the man page is:Also rename the old
default*Rlimits, because these are valid-value arrays, not defaults.Following up on the just-merged #461.