Add new two-muscle case with prestretch only#42
Conversation
|
|
|
I've started adding contraction. So now in this case you can run
or For some reason I still don't know, prestretch seems to only be applied to muscle 1. Minor todos:
|
|
|
|
The prestretch looks good apart from the fact that there are 2 mechanics and 1 fiber file, but the first contraction fiber file is the prestretched one, so that looks very good. I couldn't find why the contraction mechanics is doing exactly 10 iterations per time step, and the fibers 1, as it should. |
|
I think that now the output frequency was set to 1, which might not be good if the two solvers use different timestep sizes. Can you compare to what was the output frequency set to in a single muscle case? |
|
I have replaced the settings of the contraction part with the equivalent part of the ellipsoid contraction, and now everything works as intended. However, there are a lot of changes in the muscle contraction solver of which I don't know what they do, but it seems to work, so I left it in. Maybe you can check if this is fine this way? |
|
Thank you, I decided to undo your last changes and push again with applying only the relevant changes at the lines. (Your commit included a lot of indentation fixes, which made it hard to find out the differences) |
|
TO-DO:
To do in a different PR (each, in this order)
|
|
@Lukuas31415 says it doesn't contract. Is this indeed true? Was it contracting with commit 459e5e4?
If not:
|
|
I found the difference. Apart from a lot of indentation differences and differences in the setup of the Dynamic Hyperelasticity Solver, the main differences were the slot names. It works now as intended, and I think this is ready to be merged. |
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>


Main changes of this PR
Issues that are addressed by this PR:
Features that have been added:
Additional information
Author's checklist