Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

feat: mount src/ into /edx/app/src of frontend containers #803

Merged
kdmccormick merged 3 commits into from
Jul 29, 2021
Merged

feat: mount src/ into /edx/app/src of frontend containers #803

kdmccormick merged 3 commits into from
Jul 29, 2021

Conversation

@kdmccormick
Copy link
Contributor

@kdmccormick kdmccormick commented Jul 27, 2021 •
edited
Loading 

feat: mount src/ into /edx/app/src of frontend containers

Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.

Reviewer notes:

  • This is a PR into another PR: https://github.com/edx/devstack/pull/783
  • If there no blocking comments, I plan on merging this into main PR Thurday at 3pm ET.
  • I did not make the corresponding NFS or Docker-Sync changes, since those are going away.

@kdmccormick kdmccormick mentioned this pull request Jul 27, 2021
Closed
@kdmccormick kdmccormick force-pushed the kdmccormick/service-names-and-dependencies-frontend-mounts branch from e6ff02f to 17c5222 Compare July 27, 2021 18:43
@kdmccormick kdmccormick changed the title feat: mount src/ into /edx/src of frontend containers feat: mount src/ into /edx/app/src of frontend containers Jul 27, 2021
@kdmccormick kdmccormick force-pushed the kdmccormick/service-names-and-dependencies-frontend-mounts branch 2 times, most recently from 46d179b to d86e2ca Compare July 27, 2021 18:48
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers
3b0179e 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.
@kdmccormick kdmccormick force-pushed the kdmccormick/service-names-and-dependencies-frontend-mounts branch from d86e2ca to 3b0179e Compare July 27, 2021 18:55
@kdmccormick kdmccormick marked this pull request as ready for review July 27, 2021 18:58
@kdmccormick kdmccormick requested review from davidjoy and robrap July 27, 2021 19:31
@kdmccormick kdmccormick mentioned this pull request Jul 27, 2021
Merged
kdmccormick
kdmccormick commented Jul 27, 2021
View reviewed changes
robrap
robrap approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want (or had) someone to test the workflow, but I like the ADR and this is all set from me. Thank you!

@kdmccormick @robrap
squashme: remove typo
f77395f 
Co-authored-by: Robert Raposa <rraposa@edx.org>
@kdmccormick kdmccormick merged commit 13436d5 into kdmccormick/service-names-and-dependencies Jul 29, 2021
@kdmccormick kdmccormick deleted the kdmccormick/service-names-and-dependencies-frontend-mounts branch July 29, 2021 19:20
kdmccormick added a commit that referenced this pull request Jul 30, 2021
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers (#803)
b49d337 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.
kdmccormick added a commit that referenced this pull request Jul 30, 2021
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers (#803)
aa03e4f 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.
kdmccormick added a commit that referenced this pull request Jul 30, 2021
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers (#803)
c4de2c6 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.

TNL-8407
kdmccormick added a commit that referenced this pull request Aug 3, 2021
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers (#803)
37a834e 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.

TNL-8407
kdmccormick added a commit that referenced this pull request Aug 3, 2021
@kdmccormick
feat: mount src/ into /edx/app/src of frontend containers (#803)
1b0b65c 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.

TNL-8407
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
@kdmccormick @nsprenkle
feat: mount src/ into /edx/app/src of frontend containers (#803)
4588990 
Allows installation of local versions of NPM
packages via module.config.js, allowing frontend devs
to test out frontend library changes within devstack.

The mounts follow nearly the same pattern that micro-services
do, which allows devs to develop local versions of
Python packages alongside devstack micro-services.

See included ADR #5 for details and rationale.

TNL-8407
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidjoy davidjoy Awaiting requested review from davidjoy

1 more reviewer

@robrap robrap robrap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kdmccormick @robrap