This repository was archived by the owner on Aug 1, 2024. It is now read-only.
revert: feat!: invert dependencies so that backends now depend on frontends #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntends This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
robrap
approved these changes
Aug 9, 2021
|
|
||
| * The Learning Management System (LMS). | ||
| * LMS micro-frontends, including Gradebook and Learning (a.k.a. the "new courseware experience"). | ||
| * The Learning Management System (LMS) |
Contributor
There was a problem hiding this comment.
If you want some of these updates, do you plan to use a separate PR?
Contributor
Author
There was a problem hiding this comment.
@robrap The README formatting? I don't plan on reintroducing those changes.
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
…ntends (#815) This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other information
This reverts part of (but not all of) https://github.com/edx/devstack/pull/783. Specifically, it puts the old dependency relationships back in place, but keeps the changes to frontend app names and frontend package mounting.
I will follow up this merge with a new email to the org.